Reviewers: Jasvir, metaweta,

Description:
jquery-1.7.1 checks
  document.createElement('nav').cloneNode(true).outerHTML !==
'<:nav></:nav>'
to work around a bug in IE<=8, which returns that odd value.

In caja, the createElement throws an error, so jquery fails to start.

This change whitelists <nav>, which seems pretty harmless.

jquery rationale:
  http://bugs.jquery.com/ticket/10501
  http://bugs.jquery.com/ticket/10682

https://github.com/jquery/jquery/commit/41b31d7386cf00e714d703db773ffa73b6

Please review this at http://codereview.appspot.com/5714054/

Affected files:
  M     src/com/google/caja/lang/html/html4-elements-extensions-defs.json
M src/com/google/caja/lang/html/html4-elements-extensions-whitelist.json
  M     src/com/google/caja/plugin/domado.js


Index: src/com/google/caja/plugin/domado.js
===================================================================
--- src/com/google/caja/plugin/domado.js        (revision 4797)
+++ src/com/google/caja/plugin/domado.js        (working copy)
@@ -5539,6 +5539,7 @@
         'HTMLMenuElement',
         'HTMLMetaElement',
         'HTMLModElement',
+        'HTMLNavElement',
         'HTMLObjectElement',
         'HTMLOListElement',
         'HTMLOptGroupElement',
Index: src/com/google/caja/lang/html/html4-elements-extensions-defs.json
===================================================================
--- src/com/google/caja/lang/html/html4-elements-extensions-defs.json (revision 4797) +++ src/com/google/caja/lang/html/html4-elements-extensions-defs.json (working copy)
@@ -6,6 +6,12 @@
         "deprecated":  false,
         "description": "region which may be drawn in by scripts"
       },
+      { "key":         "NAV",
+        "empty":       false,
+        "optionalEnd": false,
+        "deprecated":  false,
+        "description": "HTML5 element, needed by jquery-1.7.1"
+      },
       { "key":         "NOBR",
         "empty":       false,
         "optionalEnd": false,
@@ -17,6 +23,6 @@
         "optionalEnd": false,
         "deprecated":  true,
         "description": "Not in HTML4. HTML5 mentions it as deprecated"
-      }
+      }
   ]
 }
Index: src/com/google/caja/lang/html/html4-elements-extensions-whitelist.json
===================================================================
--- src/com/google/caja/lang/html/html4-elements-extensions-whitelist.json (revision 4797) +++ src/com/google/caja/lang/html/html4-elements-extensions-whitelist.json (working copy)
@@ -1,6 +1,7 @@
 {
   "allowed": [
     "CANVAS",
+    "NAV",
     "NOBR",
     "NOEMBED"
   ]


Reply via email to