http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/caja.js File src/com/google/caja/plugin/caja.js (right):
http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/caja.js#newcode43 src/com/google/caja/plugin/caja.js:43: callback(result); Replaced with a try-finally. On 2012/05/02 18:58:23, metaweta wrote:
wrap this in a try...finally so that the GC always happens, then
rethrow if
necessary.
http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/caja.js#newcode256 src/com/google/caja/plugin/caja.js:256: full.cache = partial.cache || {}; No longer needed. On 2012/05/02 18:58:23, metaweta wrote:
Any worries about __proto__ here? Does guest code control URLs coming
to this
object?
http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/caja.js#newcode441 src/com/google/caja/plugin/caja.js:441: function installSyncScript(name, url) { On 2012/05/02 18:58:23, metaweta wrote:
Add a comment that urls need to be escaped before passing them in
here, since
they're controlled by guest code. The defaultFetcher is escaping the
url, so
we're ok by default.
Done. http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/guest-manager.js File src/com/google/caja/plugin/guest-manager.js (right): http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/guest-manager.js#newcode147 src/com/google/caja/plugin/guest-manager.js:147: setTimeout(opt_runDone, 1000); No longer needed. On 2012/05/02 18:58:23, metaweta wrote:
Why a full second?
http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/html-emitter.js File src/com/google/caja/plugin/html-emitter.js (right): http://codereview.appspot.com/6060046/diff/5001/src/com/google/caja/plugin/html-emitter.js#newcode418 src/com/google/caja/plugin/html-emitter.js:418: return srcIndex ? attribs[srcIndex] : undefined; On 2012/05/02 18:58:23, metaweta wrote:
Off by 1?
I do not believe so - the array is alternately key/value pairs. http://codereview.appspot.com/6060046/
