Revision: 5032 Author: [email protected] Date: Thu Aug 30 18:15:03 2012 Log: workaround for firefox defineProperty problem http://codereview.appspot.com/6492064
current firefox complains if you defineProperty of a non-configurable property of window, and leave enumerable unspecified. that's supposed to succeed, leaving enumerability unchanged. this CL is a workaround, and with this change, firefox is now unsafe level 4 "Not isolated", rather than unsafe level 5 "New symptom". firefox bug is here https://bugzilla.mozilla.org/show_bug.cgi?id=787262 [email protected] http://code.google.com/p/google-caja/source/detail?r=5032 Modified: /trunk/src/com/google/caja/ses/startSES.js ======================================= --- /trunk/src/com/google/caja/ses/startSES.js Tue Jun 12 17:26:50 2012 +++ /trunk/src/com/google/caja/ses/startSES.js Thu Aug 30 18:15:03 2012 @@ -1079,7 +1079,8 @@ var newDesc = { value: global[name], writable: false, - configurable: false + configurable: false, + enumerable: desc.enumerable // firefox bug 787262 }; try { defProp(global, name, newDesc);
