Revision: 5139
Author: [email protected]
Date: Tue Nov 6 16:00:00 2012
Log: Update obsolete comments in domado.js and narrow domitaModules
scope.
http://codereview.appspot.com/6819101
* domitaModules has no reason to be a global variable, so move it inside
the scope function.
* Update copyright date.
* Node lists are no longer not live.
* Domado may not be a “full implementation”, but it's not like we are
specifically planning to replace it with something better.
[email protected]
http://code.google.com/p/google-caja/source/detail?r=5139
Modified:
/trunk/src/com/google/caja/plugin/domado.js
=======================================
--- /trunk/src/com/google/caja/plugin/domado.js Tue Nov 6 10:03:09 2012
+++ /trunk/src/com/google/caja/plugin/domado.js Tue Nov 6 16:00:00 2012
@@ -1,4 +1,4 @@
-// Copyright (C) 2008-2011 Google Inc.
+// Copyright (C) 2008-2012 Google Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -21,12 +21,10 @@
* >ECMAScript Language Bindings</a>.
*
* Caveats:<ul>
- * <li>This is not a full implementation.
* <li>Security Review is pending.
* <li><code>===</code> and <code>!==</code> on node lists will not
* behave the same as with untamed node lists. Specifically, it is
* not always true that {@code nodeA.childNodes === nodeA.childNodes}.
- * <li>Node lists are not "live" -- do not reflect changes in the DOM.
* </ul>
*
* <p>
@@ -50,7 +48,7 @@
* @requires WeakMap, Proxy
* @requires CSS_PROP_BIT_HISTORY_INSENSITIVE
* @provides Domado
- * @overrides domitaModules, window
+ * @overrides window
*/
// The Turkish i seems to be a non-issue, but abort in case it is.
@@ -59,9 +57,6 @@
// TODO(kpreid): Review whether multiple uses of np() should be coalesced
for
// efficiency.
-// TODO(kpreid): Move this from the global scope into the function(){}();
-// eliminate the domitaModules object (or possibly move more stuff into
it).
-var domitaModules;
var Domado = (function() {
'use strict';
@@ -112,7 +107,9 @@
: null;
}
- if (!domitaModules) { domitaModules = {}; }
+ // TODO(kpreid): If not used for the upcoming
modularity-of-element-tamings
+ // refactoring, eliminate the domitaModules object.
+ var domitaModules = {};
domitaModules.proxiesAvailable = typeof Proxy !== 'undefined';
