New snapshot. Note changes to testIframeShim.

https://codereview.appspot.com/6843122/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/6843122/diff/1/src/com/google/caja/plugin/domado.js#newcode4684
src/com/google/caja/plugin/domado.js:4684: if (attrLc !== 'name' &&
attrLc !== 'src') {
On 2012/11/29 06:39:24, felix8a wrote:
doesn't this special case go away too?

Yep, it should. Removed the method entirely.

https://codereview.appspot.com/6843122/diff/1/src/com/google/caja/plugin/domado.js#newcode4693
src/com/google/caja/plugin/domado.js:4693: // ...
On 2012/11/29 06:39:24, felix8a wrote:
how about add a TODO here?

Removed the method entirely, since it does nothing. This was an artifact
of these changes having been originally written as preliminary to
implementing iframe src=, but I can always re-add this setAttribute hook
then.

https://codereview.appspot.com/6843122/

Reply via email to