New snapshot (Patch Set 2). Forgot to respond to MarkM's comments
earlier, and have now made changes.
https://codereview.appspot.com/8710044/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/8710044/diff/1/src/com/google/caja/ses/repairES5.js#newcode1855
src/com/google/caja/ses/repairES5.js:1855: var frozenInWrongFrame =
other.Object();
On 2013/04/12 19:11:43, MarkM wrote:
At this point, nothing is wrong yet, so this seems a confusing name.
Renamed to frozenInOtherFrame.
https://codereview.appspot.com/8710044/diff/1/src/com/google/caja/ses/repairES5.js#newcode1856
src/com/google/caja/ses/repairES5.js:1856: var fwfok;
On 2013/04/12 19:11:43, MarkM wrote:
What does fwfok stand for?
Renamed to freezeSucceeded.
https://codereview.appspot.com/8710044/diff/1/src/com/google/caja/ses/repairES5.js#newcode1870
src/com/google/caja/ses/repairES5.js:1870: // adequate repair
On 2013/04/12 19:25:02, ihab.awad wrote:
What condition would fall through to here?
This is the state which the repair achieves: the other frame's freeze
will throw on foreign objects, so the object never gets a bogus frozen
flag (both !isFrozen) but freeze threw when it shouldn't (!fwfok).
https://codereview.appspot.com/8710044/diff/1/src/com/google/caja/ses/repairES5.js#newcode2819
src/com/google/caja/ses/repairES5.js:2819: fix('freeze');
On 2013/04/12 19:11:43, MarkM wrote:
What about fix('seal') ?
Done.
I knew I needed to fix every operation which sets [[Extensible]] to
false, but was confused and thought that seal was not such an operation.
I've also skimmed the spec to confirm that this is now a complete list,
and added a note about what the list is.
https://codereview.appspot.com/8710044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
