https://codereview.appspot.com/8806045/diff/13001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/8806045/diff/13001/src/com/google/caja/ses/repairES5.js#newcode2118
src/com/google/caja/ses/repairES5.js:2118: 'Repaired Object.create can
not support Object.create(null)') {
On 2013/04/17 18:21:11, MarkM wrote:
If you're going to compare with a long sentence like this, make it a
symbol
constant and refer to it from everywhere it needs to be the same.
Done.
https://codereview.appspot.com/8806045/diff/13001/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):
https://codereview.appspot.com/8806045/diff/13001/src/com/google/caja/ses/startSES.js#newcode564
src/com/google/caja/ses/startSES.js:564: // (that is, if they occur in
freeNames).
On 2013/04/17 18:21:11, MarkM wrote:
In which case they will obtain the values of these properties from the
imports
object, which would now inherit them from Object.prototype. This is
fine, but
contradicts the safety comment there.
I don't follow. The comment here is saying that the correct behavior
will be preserved here (due to overriding). The comment on imports is
saying that it is visibly incorrect (contains the extra properties), but
safe because those properties are ambiently available.
https://codereview.appspot.com/8806045/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
