The remark in es53-test-scan-guest.js is the only "important" one; all
else is advisory.
https://codereview.appspot.com/9731044/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/9731044/diff/1/src/com/google/caja/plugin/domado.js#newcode3463
src/com/google/caja/plugin/domado.js:3463: privates.setT = setTransform;
Are getTransform and setTransform always the same thing throughout
Domado?
https://codereview.appspot.com/9731044/diff/1/src/com/google/caja/plugin/domado.js#newcode3479
src/com/google/caja/plugin/domado.js:3479: add:
Props.ampMethod(function(privates, ttoken) {
Shouldn't these methods be defined down on the "settable" variant since
they are arguably setters?
https://codereview.appspot.com/9731044/diff/1/src/com/google/caja/plugin/domado.js#newcode3496
src/com/google/caja/plugin/domado.js:3496: function(ftoken) {
What are the pros and cons of doing it this way versus iterating using
the feral-side .length and .item()?
https://codereview.appspot.com/9731044/diff/1/src/com/google/caja/plugin/domado.js#newcode3514
src/com/google/caja/plugin/domado.js:3514: return
privates.feral.value.replace(/[^ \t\n\r\f]+/g, function(s) {
linewrap nit
https://codereview.appspot.com/9731044/diff/1/tests/com/google/caja/plugin/es53-test-scan-guest.js
File tests/com/google/caja/plugin/es53-test-scan-guest.js (right):
https://codereview.appspot.com/9731044/diff/1/tests/com/google/caja/plugin/es53-test-scan-guest.js#newcode1431
tests/com/google/caja/plugin/es53-test-scan-guest.js:1431:
argsByProp('addEventListener', argsByProp('removeEventListener',
add vs. remove? confused about this line....
https://codereview.appspot.com/9731044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
