https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/plugin/ses-frame-group.js
File src/com/google/caja/plugin/ses-frame-group.js (right):
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/plugin/ses-frame-group.js#newcode35
src/com/google/caja/plugin/ses-frame-group.js:35: // TODO(kpreid): make
sure mitigator is applied to guest code only
On 2013/06/04 17:26:46, kpreid2 wrote:
You may delete this TODO: it refers to mitigating Domado-and-friends,
which we
know doesn't apply.
Done.
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/ses/compileExprLater.js
File src/com/google/caja/ses/compileExprLater.js (right):
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/ses/compileExprLater.js#newcode111
src/com/google/caja/ses/compileExprLater.js:111: JSON.stringify(options)
+ ')));';
On 2013/06/04 17:26:46, kpreid2 wrote:
this entire statement should be 4-space indent
Done.
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/ses/startSES.js#newcode314
src/com/google/caja/ses/startSES.js:314: ses.resolveOptions =
resolveOptions;
On 2013/06/04 17:26:46, kpreid2 wrote:
I am concerned that 'ses' is becoming a mixed bundle of internal
components and
public interface.
Acknowledged. I didn't do this at first but then found I needed to
access it from compileExprLater.
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/ses/startSES.js#newcode638
src/com/google/caja/ses/startSES.js:638: var result;
On 2013/06/04 17:26:46, kpreid2 wrote:
unused
Done.
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/ses/startSES.js#newcode639
src/com/google/caja/ses/startSES.js:639: function
wrappedResult(var_args) {
On 2013/06/04 17:26:46, kpreid2 wrote:
unused
Done.
https://codereview.appspot.com/9945043/diff/22001/src/com/google/caja/ses/startSES.js#newcode803
src/com/google/caja/ses/startSES.js:803: * unimplemented.
On 2013/06/04 17:26:46, kpreid2 wrote:
Please file an issue for implementing this.
Done.
https://codereview.appspot.com/9945043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
