Reviewers: kpreid2,
Description:
Browser tests names are now something like 'cajajs-invocation-min-es53',
which is the name you'd use to run one test with -Dtest.filter.method,
but these names are not anywhere literally in the source any more,
and it's not obvious how to construct a valid name.
The test names are visible in the ant test report summary, but
test-index.html annoyingly does not show these test names.
It's possible to construct a valid test name from the info on
test-index.html, but the method for doing that is not obvious.
This change makes it obvious. test-index.html used to look like:
cajajs
invocation
es53 es5 nomin
es53 es5 min
es53[min nomin] es5[min nomin] version-skew-js-files
It now looks like:
cajajs-
invocation-
nomin- {es53 es5}
min- {es53 es5}
version-skew-js-files- {es53- {min nomin} es5- {min nomin}}
Please review this at https://codereview.appspot.com/10222043/
Affected files:
M tests/com/google/caja/plugin/test-index.html
M tests/com/google/caja/plugin/test-index.js
Index: tests/com/google/caja/plugin/test-index.html
===================================================================
--- tests/com/google/caja/plugin/test-index.html (revision 5443)
+++ tests/com/google/caja/plugin/test-index.html (working copy)
@@ -25,14 +25,23 @@
background: white;
color: #777;
font-size: 0.8em;
+ padding-left: 2em;
white-space: pre-wrap;
}
+
[title] { border-right: .5em solid #ccc; }
#key { display: table; float: right; background-color: #EEE; padding:
1em; }
#key h3 { text-align: center; margin: 0; }
#key ul { margin: 0; padding: 0; }
#key li { margin: 0; padding: 0; list-style-type: none; }
+
+ .testlist li {
+ list-style-type: none;
+ }
+ .testlist, .testlist ul {
+ padding-left: 2em;
+ }
</style>
<body>
<div id="key">
@@ -45,9 +54,9 @@
</ul>
</div>
<h2>End-to-end automated tests</h2>
- <ul id='tests'></ul>
+ <ul id='tests' class='testlist'></ul>
<h2>Third-party tests</h2>
- <ul id='thirdparty'></ul>
+ <ul id='thirdparty' class='testlist'></ul>
<h2>Manual tools</h2>
<ul>
<li><a href="../../../../../src/com/google/caja/ses/explicit.html">
Index: tests/com/google/caja/plugin/test-index.js
===================================================================
--- tests/com/google/caja/plugin/test-index.js (revision 5443)
+++ tests/com/google/caja/plugin/test-index.js (working copy)
@@ -30,15 +30,16 @@
return {
addGroup: function(label, comment) {
var entry = list.appendChild(document.createElement('li'));
- entry.appendChild(document.createTextNode(label));
+ entry.appendChild(document.createTextNode(label + '-'));
headerComment(entry, comment);
var sublist = entry.appendChild(document.createElement('ul'));
return makeCatalogOutput(sublist);
},
addMiniGroup: function(label, comment) {
var entry = list.appendChild(document.createElement('li'));
+ entry.appendChild(document.createTextNode(label + '- {'));
var sublist = entry.appendChild(document.createElement('span'));
- entry.appendChild(document.createTextNode(' ' + label));
+ entry.appendChild(document.createTextNode('}'));
headerComment(entry, comment);
return makeMiniOutput(sublist);
},
@@ -69,9 +70,9 @@
space();
var entry = list.appendChild(document.createElement('span'));
hiddenComment(entry, comment);
- entry.appendChild(document.createTextNode(label + '['));
+ entry.appendChild(document.createTextNode(label + '- {'));
var sublist = entry.appendChild(document.createElement('span'));
- entry.appendChild(document.createTextNode(']'));
+ entry.appendChild(document.createTextNode('}'));
return makeMiniOutput(sublist);
}
return {
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
