Reviewers: kpreid2,
Description:
some automode tests use an impossibly strict severity level
named MAGICAL_UNICORN to force a switch to es53.
repairES5 validates severity levels and rejects MAGICAL_UNICORN,
replacing it with SAFE_SPEC_VIOLATION.
firefox 22 meets the standard of SAFE_SPEC_VIOLATION, so the
automode tests fail to switch to es53, causing the tests to fail.
this fix admits MAGICAL_UNICORN exists
Please review this at https://codereview.appspot.com/10341043/
Affected files:
M src/com/google/caja/ses/repairES5.js
Index: src/com/google/caja/ses/repairES5.js
===================================================================
--- src/com/google/caja/ses/repairES5.js (revision 5449)
+++ src/com/google/caja/ses/repairES5.js (working copy)
@@ -219,7 +219,7 @@
if (severityName) {
var sev = ses.severities[severityName];
if (sev && typeof sev.level === 'number' &&
- sev.level >= ses.severities.SAFE.level &&
+ sev.level >= ses.severities.MAGICAL_UNICORN.level &&
sev.level < ses.severities.NOT_SUPPORTED.level) {
// do nothing
} else {
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
