Revision: 5452
Author: [email protected]
Date: Mon Jun 17 21:21:52 2013
Log: downgrade css identifier error from FATAL to WARNING
https://codereview.appspot.com/10347044
for some reason, a CSS selector like "input:-moz-placeholder" is
a fatal error in es53, and it aborts processing.
I don't see a reason for this to be a fatal eror, so I'm downgrading
it to a warning. It's safe to do that because the warning still
marks that css rule as invalid, and it gets removed later.
this fixes https://code.google.com/p/google-caja/issues/detail?id=1768
R=ihab.awad
http://code.google.com/p/google-caja/source/detail?r=5452
Modified:
/trunk/src/com/google/caja/plugin/PluginMessageType.java
=======================================
--- /trunk/src/com/google/caja/plugin/PluginMessageType.java Wed Jun 12
12:17:07 2013
+++ /trunk/src/com/google/caja/plugin/PluginMessageType.java Mon Jun 17
21:21:52 2013
@@ -56,8 +56,8 @@
"%s: css property %s with value %s not in range [%s, %s]",
MessageLevel.WARNING),
UNSAFE_CSS_IDENTIFIER(
- "%s: css identifier '%s' contains characters that may not work"
- + " on all browsers", MessageLevel.FATAL_ERROR),
+ "%s: potentially unsafe css identifier '%s'",
+ MessageLevel.WARNING),
UNSAFE_CSS_PROPERTY("%s: unsafe css property %s", MessageLevel.ERROR),
UNSAFE_CSS_PSEUDO_SELECTOR(
"%s: unsafe css pseudo-selector %s", MessageLevel.ERROR),
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
