lgtm except typo noted below
https://codereview.appspot.com/10438046/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json
File src/com/google/caja/lang/css/css-extensions-defs.json (right):
https://codereview.appspot.com/10438046/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode506
src/com/google/caja/lang/css/css-extensions-defs.json:506: "signature":
"[ closest-side | farthest-side | closest-corner | farthest-corner |
<length> | [<length> | <precentage>] [<length> | <precentage>] ]",
<precentage> should be <percentage>. why didn't that raise an error?
https://codereview.appspot.com/10438046/diff/1/src/com/google/caja/lang/css/css-extensions-defs.json#newcode508
src/com/google/caja/lang/css/css-extensions-defs.json:508: "comment":
"Why is this called size and not side?",
it's not necessarily a side. it's how far the gradient pattern extends,
so 'size' is the right name
https://codereview.appspot.com/10438046/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
