Note that this cannot be submitted until I know what to do about the ses.mitigateSrcGotchas issue I raise below.
On Sat, Jul 6, 2013 at 1:34 PM, <[email protected]> wrote: > > https://codereview.appspot.**com/10181043/diff/27001/src/** > com/google/caja/ses/**exportsToSES.js<https://codereview.appspot.com/10181043/diff/27001/src/com/google/caja/ses/exportsToSES.js> > File src/com/google/caja/ses/**exportsToSES.js (left): > > https://codereview.appspot.**com/10181043/diff/27001/src/** > com/google/caja/ses/**exportsToSES.js#oldcode36<https://codereview.appspot.com/10181043/diff/27001/src/com/google/caja/ses/exportsToSES.js#oldcode36> > src/com/google/caja/ses/**exportsToSES.js:36: delete global.exports; > Because createExports.js is creating the global "exports" with a top > level "var", it is non-configurable and so the delete above was always > failing. Only when I habitually made the enclosing function strict did I > notice this failure. > > https://codereview.appspot.**com/10181043/diff/27001/src/** > com/google/caja/ses/repairES5.**js<https://codereview.appspot.com/10181043/diff/27001/src/com/google/caja/ses/repairES5.js> > File src/com/google/caja/ses/**repairES5.js (right): > > https://codereview.appspot.**com/10181043/diff/27001/src/** > com/google/caja/ses/repairES5.**js#newcode3382<https://codereview.appspot.com/10181043/diff/27001/src/com/google/caja/ses/repairES5.js#newcode3382> > src/com/google/caja/ses/**repairES5.js:3382: } else if (typeof > ses.mitigateSrcGotchas === 'function') { > Unfortunately, at this point in the initialization process > ses.mitigateSrcGotchas is not yet initialized. What is the right way to > fix Caja so this is already initialized by the time we get here? > > https://codereview.appspot.**com/10181043/<https://codereview.appspot.com/10181043/> > > -- > > ---You received this message because you are subscribed to the Google > Groups "Google Caja Discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to > google-caja-discuss+**[email protected]<google-caja-discuss%[email protected]> > . > For more options, visit > https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> > . > > > -- Cheers, --MarkM -- --- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
