https://codereview.appspot.com/10963044/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java
File tests/com/google/caja/plugin/WebDriverHandle.java (right):
https://codereview.appspot.com/10963044/diff/1/tests/com/google/caja/plugin/WebDriverHandle.java#newcode116
tests/com/google/caja/plugin/WebDriverHandle.java:116: // we just re-use
the same window.
This will greatly interfere with my workflow, as opening and navigating
the report files is much less convenient than copying URLs out of open
browser windows (or, sometimes, viewing the failure directly in the
left-open window). Furthermore, in the case of third-party-tests, it is
often the case that one wishes to review the pass-count differences
among all tests, which information is not stored in the report; the
alternative would be to manually run all tests or rerun failed tests,
which is tediously slow.
Here are two alternate solutions I can think of:
1. Use multiple windows if possible and fall back to a single window if
not.
2. Open windows by navigating the browser to a page which opens windows,
rather than using executeScript; a unique name can be provided via
parameters in the URL.
This change would be more acceptable given the following improvements to
reporting:
A. Report more specific failure information from JS tests. Minimal fix
would be to have the qunit-test-driver arrange so the QUnit pass count
ends up in the title (which does get into the report); ideal would be to
pass back all of the jsunit failing tests with their corresponding
exceptions.
B. After a test run, output to stdout the URLs (preferably with port set
to 8000) of all failed browser tests.
https://codereview.appspot.com/10963044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
