https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/StringMap.js
File src/com/google/caja/ses/StringMap.js (right):
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/StringMap.js#newcode20
src/com/google/caja/ses/StringMap.js:20: * @overrides ses
On 2013/07/09 16:34:59, kpreid2 wrote:
Instead of @overrides (I assume this is needed because of the var
declaration?),
how about replacing the || {} chain with
if (typeof ses !== 'undefined' &&
ses.es5ProblemReports.FREEZING_BREAKS_PROTOTYPES.beforeFailure)
This will fail if the intermediate objects are missing, but that is an
appropriate inconsistency-failure to catch.
Done.
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/StringMap.js#newcode28
src/com/google/caja/ses/StringMap.js:28: "use strict";
On 2013/07/09 16:34:59, kpreid2 wrote:
While we're fixing minor things: single quotes.
Done.
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/compileExprLater.js
File src/com/google/caja/ses/compileExprLater.js (right):
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/compileExprLater.js#newcode111
src/com/google/caja/ses/compileExprLater.js:111: if (options.sourceUrl)
{
On 2013/07/09 16:34:59, kpreid2 wrote:
This condition is incorrect because the empty string is falsy and is a
valid
(relative) URL. Even if relative URLs are useless here we shouldn't
treat them
as absent.
Done. Good catch.
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/startSES.js#newcode1438
src/com/google/caja/ses/startSES.js:1438: if (result === '*') {
On 2013/07/09 16:34:59, kpreid2 wrote:
Note that my current typed-array-support draft requires 'skip'. I plan
to look
into whether there's something we can do which is stricter than
'skip', but I
haven't done so yet.
You can still remove 'skip' now; I'm just noting that I might end up
making
semi-reverting changes here.
(The problem — I forget whether I explained this already — is that the
typed
array prototypes have accessor properties, and the whitelist mechanism
essentially assumes that every built-in property is a data property
(var sub =
value[name]; in the register function), which is true for ES5, but not
for typed
arrays as implemented now and as in ES6-draft.)
Acknowledged. I am proceeding to remove it now. Add back in what you
find useful when you need it.
https://codereview.appspot.com/10075043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
