Revision: 5491
Author:   [email protected]
Date:     Mon Jul 15 10:46:44 2013
Log:      Don't not repair PUSH_IGNORES_FROZEN.
https://codereview.appspot.com/10746046

We have no reason not to run the repair for PUSH_IGNORES_FROZEN rather
than failing; it was kept disabled in r5442 only due to sloppy thinking
about preserving existing behavior.

Makes ES5 mode able to run on Chrome versions suffering from
<https://code.google.com/p/v8/issues/detail?id=2711>.

Addresses <https://code.google.com/p/google-caja/issues/detail?id=1808>.

[email protected], [email protected]

http://code.google.com/p/google-caja/source/detail?r=5491

Modified:
 /trunk/src/com/google/caja/plugin/caja.js

=======================================
--- /trunk/src/com/google/caja/plugin/caja.js   Thu Jul 11 18:45:27 2013
+++ /trunk/src/com/google/caja/plugin/caja.js   Mon Jul 15 10:46:44 2013
@@ -443,9 +443,8 @@
           'DEFINING_READ_ONLY_PROTO_FAILS_SILENTLY': { 'permit': true },

// we don't use partly-unmodifiable arrays, and the repair for push
-          // is too slow
+          // is too slow to use unless necessary (i.e. PUSH_IGNORES_FROZEN)
           'PUSH_IGNORES_SEALED': { 'permit': true, 'doNotRepair': true },
-          'PUSH_IGNORES_FROZEN': { 'doNotRepair': true },
           'PUSH_DOES_NOT_THROW_ON_FROZEN_ARRAY':
               { 'permit': true, 'doNotRepair': true },
           'ARRAYS_DELETE_NONCONFIGURABLE': { 'permit': true },

--

--- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to