Revision: 5496
Author: [email protected]
Date: Wed Jul 17 09:57:52 2013
Log: fix event test for firefox 23 (beta) and 24 (aurora)
https://codereview.appspot.com/11416044
keyboard events are supposed to have an event.key property, which is
the new hotness obsoleting event.keyCode. firefox doesn't implement
event.key yet, and different versions of firefox fail to implement
event.key in different ways.
firefox 22 doesn't have an event.key property.
firefox 23 and 24 has an event.key property and it seems to be always ''.
the '' value is causing a spurious browser test failure.
this mutes that failure.
this fixes https://code.google.com/p/google-caja/issues/detail?id=1805
R=kpreid2
http://code.google.com/p/google-caja/source/detail?r=5496
Modified:
/trunk/tests/com/google/caja/plugin/es53-test-domado-events-guest.html
=======================================
--- /trunk/tests/com/google/caja/plugin/es53-test-domado-events-guest.html
Tue Jul 2 11:36:56 2013
+++ /trunk/tests/com/google/caja/plugin/es53-test-domado-events-guest.html
Wed Jul 17 09:57:52 2013
@@ -936,7 +936,9 @@
if (directAccess.feralFeatureTest(event, 'char')) {
assertEquals('initKeyboardEvent char', 'q', event.char);
}
- if (directAccess.feralFeatureTest(event, 'key')) {
+ // firefox 23 and 24 have event.key but it seems to always be ''
+ if (directAccess.feralFeatureTest(event, 'key') &&
+ directAccess.getFeralProperty(event, 'key') !== '') {
assertEquals('initKeyboardEvent key', 'q', event.key);
}
assertEquals('initKeyEvent charCode', 0, event.charCode);
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
