https://codereview.appspot.com/11756043/diff/4001/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):
https://codereview.appspot.com/11756043/diff/4001/src/com/google/caja/plugin/sanitizecss.js#newcode646
src/com/google/caja/plugin/sanitizecss.js:646: var MEDIA_EXPR = '\\( ' +
MEDIA_FEATURE + ' (?:' + ': ' + CSS_VALUE + ' )?\\)';
long line
https://codereview.appspot.com/11756043/diff/4001/src/com/google/caja/plugin/sanitizecss.js#newcode672
src/com/google/caja/plugin/sanitizecss.js:672: * by cssLexers.
either note this modifies cssTokens, or change the function to not
modify cssTokens
https://codereview.appspot.com/11756043/diff/4001/src/com/google/caja/plugin/sanitizecss.js#newcode687
src/com/google/caja/plugin/sanitizecss.js:687: :
!(MEDIA_QUERY_LIST_REGEXP.test(css)) ? 'not all' // Always false.za
stray "za" at end
https://codereview.appspot.com/11756043/diff/4001/tests/com/google/caja/plugin/sanitizecss_test.js
File tests/com/google/caja/plugin/sanitizecss_test.js (right):
https://codereview.appspot.com/11756043/diff/4001/tests/com/google/caja/plugin/sanitizecss_test.js#newcode447
tests/com/google/caja/plugin/sanitizecss_test.js:447: return
css.replace(/(^|[^\w\-]) | (?=$|[^\w\-])/g, '$1').toLowerCase();
I'm not sure what this replace is supposed to do?
I think it's removing space after and before punctuation, but it took me
a while to reach that conclusion.
maybe split it up into two substitutions and add a comment?
https://codereview.appspot.com/11756043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
