https://codereview.appspot.com/11832043/diff/3001/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):

https://codereview.appspot.com/11832043/diff/3001/src/com/google/caja/plugin/sanitizecss.js#newcode24
src/com/google/caja/plugin/sanitizecss.js:24: * \@requires
CSS_PROP_BIT_GLOBAL_NAME
On 2013/07/25 18:01:15, felix8a wrote:
move before HASH_VALUE for alphabetical order

Done.

https://codereview.appspot.com/11832043/diff/3001/src/com/google/caja/plugin/sanitizecss.js#newcode812
src/com/google/caja/plugin/sanitizecss.js:812: &&
!/__$|[^#0-9A-Za-z:_\-]/.test(animationId)) {
On 2013/07/25 18:01:15, felix8a wrote:
this regex allows ':' and '#' but the GLOBAL_NAME regex above doesn't.
should
they be the same?

Good catch.

I'm not sure what to do since ":" would be a separate token.  I could
merge the headerArray on empty string to get the animationId, but doing
that in the property name is going to complicate things, so I dropped
the : and # from here.

https://codereview.appspot.com/11832043/

--

--- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to