On 2013/07/25 23:51:51, MikeSamuel wrote:
https://codereview.appspot.com/11871043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/11871043/diff/1/src/com/google/caja/plugin/domado.js#newcode2005
src/com/google/caja/plugin/domado.js:2005: cssVirtualization = {
On 2013/07/25 22:10:37, kpreid2 wrote:
> On 2013/07/25 22:04:38, MikeSamuel wrote:
> > On 2013/07/25 21:35:17, kpreid2 wrote:
> > > This is duplicated code. The 'virtualization' object is already
this; just
> add
> > > the needed pieces to it. Maybe rename 'rewriteUri' to
'rewriteUriForCss'
to
> > > clarify the special behavior.
> >
> > The one at L 2109?
> > Hmm. I think the baseUri needs to be sensitive to setBase.
>
> Then make it .getBaseUri() or an accessor property.
>
> > Is it kosher to use Object.create to derive cssVirtualization from
> > virtualization each time sanitize is called?
>
> Why introduce a separate object? The whole point of the
virtualization object
is
> to be a bundle of _all_ the value-transformations and related info.
I
introduced
> it to cut down on function parameter counts, and arbitrary invention
of
> specialized interfaces used in only one place.
Done.
For some reason `myvn snapshot` decided to create a new CL 1183043
instead of updating this one.
I'm closing this.
https://codereview.appspot.com/11871043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
