https://codereview.appspot.com/11883043/diff/5001/src/com/google/caja/plugin/html-emitter.js
File src/com/google/caja/plugin/html-emitter.js (right):
https://codereview.appspot.com/11883043/diff/5001/src/com/google/caja/plugin/html-emitter.js#newcode518
src/com/google/caja/plugin/html-emitter.js:518: var virtualization =
Object.create(domicile.virtualization);
Why does this exist as a distinct object? What is the difference in ...
oh, I see. The base URI for the stylesheet is different from the base
URI for the document.
I missed that point before.
Perhaps base URI should be _not_ in virtualization, and rewriteCssUri
should take it as a parameter rather than closing over it?
But this is OK for now too — maybe leave a comment.
https://codereview.appspot.com/11883043/diff/5001/src/com/google/caja/plugin/html-sanitizer.js
File src/com/google/caja/plugin/html-sanitizer.js (right):
https://codereview.appspot.com/11883043/diff/5001/src/com/google/caja/plugin/html-sanitizer.js#newcode905
src/com/google/caja/plugin/html-sanitizer.js:905: var virtualization = {
It seems wrong (and potentially bad for performance) that this is being
constructed anew for every property. I suggest changing the interface of
'virtualization.rewriteCssUri' so that it does not have to close over
normProp.
https://codereview.appspot.com/11883043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
