lgtm
https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/domado.js#newcode1435
src/com/google/caja/plugin/domado.js:1435: * clearInterval that only
allow simple functions as timeouts and
fix comment?
https://codereview.appspot.com/12926048/diff/1/src/com/google/caja/plugin/domado.js#newcode7035
src/com/google/caja/plugin/domado.js:7035: function (code) { // no time
arg
I'd rather the function signature match, like maybe
function (code, ignore)
https://codereview.appspot.com/12926048/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):
https://codereview.appspot.com/12926048/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode467
tests/com/google/caja/plugin/test-domado-events-guest.html:467: function
testRequestAnimationFrame() {
this test might fail when the test browser is in the background, since
the browser doesn't have to generate animation events when the window
isn't visible. that isn't likely to happen in any normal test setup, but
maybe add a comment?
https://codereview.appspot.com/12926048/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
