new snapshot
https://codereview.appspot.com/13024043/diff/1/tests/com/google/caja/plugin/test-scan-guest.js
File tests/com/google/caja/plugin/test-scan-guest.js (right):
https://codereview.appspot.com/13024043/diff/1/tests/com/google/caja/plugin/test-scan-guest.js#newcode412
tests/com/google/caja/plugin/test-scan-guest.js:412: forEach:
function(f) {
On 2013/08/20 22:58:38, felix8a wrote:
this seems to me a very weird place to have a forEach. It ends up
being
called only once, and it's not immediately obvious why other types of
Refs
don't have a forEach, or why Ref.is does have a forEach.
maybe RefAnyFrame should be split into two functions, one that returns
an
Array and another that returns a Ref based on the Array?
I was going to argue against 'called only once' as evidence because I
deliberately didn't fully refactor to use Ref everywhere simply to avoid
large merge conflicts with other scanner changes in my queue, but I now
see that there really is only one use of it. And multiple frames will go
away when ES5/3 does. So, changed as you suggest.
https://codereview.appspot.com/13024043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
