Reviewers: kpreid2,
Description:
The version of selenium we're using has some flakiness talking to
firefox 24 (beta)
Symptom is, occasional timeout when starting a browser.
Upgrading to selenium 2.35.0 seems to fix that.
I'm also upping the timeout for es53 scan to 5 minutes, because it
sometimes
times out when I'm doing something else at the same time.
(this CL doesn't include the update to selenium-standalone.jar because
codereview barfs on huge files like that)
Please review this at https://codereview.appspot.com/13179044/
Affected files:
M tests/com/google/caja/plugin/MainBrowserTest.java
M third_party/java/webdriver/README
M third_party/java/webdriver/VERSION
Index: tests/com/google/caja/plugin/MainBrowserTest.java
===================================================================
--- tests/com/google/caja/plugin/MainBrowserTest.java (revision 5573)
+++ tests/com/google/caja/plugin/MainBrowserTest.java (working copy)
@@ -34,7 +34,7 @@
@Override
protected int waitForCompletionTimeout() {
if (entry.getLabel().startsWith("guest-scan-es53-")) {
- return 160000; // msec
+ return 300000; // msec
} else if (entry.getLabel().startsWith("guest-scan-es5-")) {
return 60000; // msec
} else {
Index: third_party/java/webdriver/README
===================================================================
--- third_party/java/webdriver/README (revision 5573)
+++ third_party/java/webdriver/README (working copy)
@@ -1,8 +1,2 @@
origin
-
https://code.google.com/p/selenium/source/detail?r=bb3450e3ab26336b7e16613c7d9063957f9cb1c3
-
-rebuild steps:
- git clone https://code.google.com/p/selenium/
- cd selenium
- git checkout bb3450e3ab26
- ./go selenium-server-standalone
+
https://code.google.com/p/selenium/downloads/detail?name=selenium-server-standalone-2.35.0.jar
Index: third_party/java/webdriver/VERSION
===================================================================
--- third_party/java/webdriver/VERSION (revision 5573)
+++ third_party/java/webdriver/VERSION (working copy)
@@ -1,2 +1,2 @@
-Version: bb3450e3ab26 (2013-07-22 trunk after 2.33.0)
-URL:
https://code.google.com/p/selenium/source/detail?r=bb3450e3ab26336b7e16613c7d9063957f9cb1c3
+Version: 2.35.0
+URL:
https://code.google.com/p/selenium/downloads/detail?name=selenium-server-standalone-2.35.0.jar
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
