https://codereview.appspot.com/13171045/diff/1/src/com/google/caja/ses/explicit.html
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/13171045/diff/1/src/com/google/caja/ses/explicit.html#newcode73
src/com/google/caja/ses/explicit.html:73: var testSignals =
gebi('testSignals');
I'd like to see the Caja test glue factored out so that the separation
between SES issues and Caja issues is clearer.

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/BrowserTestCase.java
File tests/com/google/caja/plugin/BrowserTestCase.java (right):

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/BrowserTestCase.java#newcode179
tests/com/google/caja/plugin/BrowserTestCase.java:179:
label.startsWith("guest-scan-") ||
For now, at least make this method return false and override it in
MainBrowserTest.

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/browser-tests.json
File tests/com/google/caja/plugin/browser-tests.json (right):

https://codereview.appspot.com/13171045/diff/1/tests/com/google/caja/plugin/browser-tests.json#newcode14
tests/com/google/caja/plugin/browser-tests.json:14: "label":
"ses-explicit",
This should go in ses-tests.json, no?

https://codereview.appspot.com/13171045/

--

--- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to