https://codereview.appspot.com/13271044/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/13271044/diff/1/src/com/google/caja/plugin/domado.js#newcode1445
src/com/google/caja/plugin/domado.js:1445: // call, syntax occurs occur
async.
On 2013/08/27 23:48:55, ihab.awad wrote:
You mean "syntax errors". And yes, I noticed. Very nice.
Done.
https://codereview.appspot.com/13271044/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):
https://codereview.appspot.com/13271044/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode509
tests/com/google/caja/plugin/test-domado-events-guest.html:509: ['str',
'toString'].forEach(function(name) {
On 2013/08/27 23:48:55, ihab.awad wrote:
why are "str" and "toString" special names to test here?
They're just the suffixes of the functions being called from the eval'd
callbacks.
I've edited the code to make what it's doing more explicit; please take
another look.
https://codereview.appspot.com/13271044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
