https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMap.js
File src/com/google/caja/ses/WeakMap.js (right):
https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMap.js#newcode374
src/com/google/caja/ses/WeakMap.js:374: if (!(this instanceof
OurWeakMap)) {
On 2013/09/10 22:33:30, MarkM wrote:
Add comment noting that this test is imperfect,
Done.
In fact, it is extraordinarily hard to write a perfect test for this
in ES5.
Since the purpose here is only to catch accident, this is fine.
Indeed.
https://codereview.appspot.com/13348055/diff/1/src/com/google/caja/ses/WeakMap.js#newcode521
src/com/google/caja/ses/WeakMap.js:521: // Be no more lenient than
future ES6 WeakMap
On 2013/09/10 22:33:30, MarkM wrote:
Same comment should be reachable from both, either by copying or by
reference.
Done.
https://codereview.appspot.com/13348055/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
