https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/AbstractCajaAntTask.java
File src/com/google/caja/tools/AbstractCajaAntTask.java (right):
https://codereview.appspot.com/13826049/diff/1/src/com/google/caja/tools/AbstractCajaAntTask.java#newcode94
src/com/google/caja/tools/AbstractCajaAntTask.java:94: logger.close();
On 2013/09/24 17:39:57, felix8a wrote:
On 2013/09/24 16:51:20, kpreid2 wrote:
> I'm worried that this only works by accident. Does Ant's API
documentation
> have something to say about the lifetime of getLogger()?
it's our getLogger, defined at line 116 below. I'll make it private.
Oh, I see, it's not-really-closeable. Erf.
How about calling the method makeLogger?
https://codereview.appspot.com/13826049/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
