Reviewers: kpreid2,
Description:
com.google.common.collect.Maps from Guava does the same thing.
The comment at the top of the Maps class is referring to a very
old version of the google collections library, which was fixed
to be like this Maps class, and then absorbed into Guava.
the deletion of one of the newTreeBag factory methods is because
the necessary generics turn out to be weird, because of bugs in
various versions of javac. since we're not using that method
I just deleted it instead.
Please review this at https://codereview.appspot.com/13861043/
Affected files (+66, -62 lines):
M src/com/google/caja/ancillary/linter/ErrorReporter.java
M src/com/google/caja/ancillary/linter/ExitModes.java
M src/com/google/caja/ancillary/linter/Linter.java
M src/com/google/caja/ancillary/linter/SymbolTable.java
M src/com/google/caja/ancillary/opt/ConstLocalOptimization.java
M src/com/google/caja/ancillary/opt/ConstantPooler.java
M src/com/google/caja/ancillary/opt/EnvironmentData.java
M src/com/google/caja/ancillary/opt/ParseTreeKB.java
M src/com/google/caja/ancillary/opt/ScopeInfo.java
M src/com/google/caja/ancillary/opt/StatementSimplifier.java
M src/com/google/caja/lang/css/CssPropertyPatterns.java
M src/com/google/caja/lang/css/Partitions.java
M src/com/google/caja/lang/html/HtmlDefinitions.java
M src/com/google/caja/lang/html/HtmlSchema.java
M src/com/google/caja/lexer/HtmlTextEscapingMode.java
M src/com/google/caja/parser/html/DoctypeMaker.java
M src/com/google/caja/parser/html/Html5ElementStack.java
M src/com/google/caja/parser/js/JsonMLConverter.java
M src/com/google/caja/parser/quasiliteral/AlphaRenaming.java
M src/com/google/caja/parser/quasiliteral/AlphaRenamingRewriter.java
M src/com/google/caja/parser/quasiliteral/NameContext.java
M src/com/google/caja/parser/quasiliteral/QuasiCache.java
M src/com/google/caja/parser/quasiliteral/Rule.java
M src/com/google/caja/parser/quasiliteral/RuleFilter.java
M src/com/google/caja/parser/quasiliteral/Scope.java
M src/com/google/caja/parser/quasiliteral/opt/ScopeTree.java
M src/com/google/caja/plugin/BuildServiceImplementation.java
M src/com/google/caja/plugin/PluginCompilerMain.java
M src/com/google/caja/plugin/stages/RewriteFlashStage.java
M src/com/google/caja/plugin/stages/ValidateJavascriptStage.java
M src/com/google/caja/plugin/templates/HtmlAttributeRewriter.java
M src/com/google/caja/plugin/templates/SafeHtmlMaker.java
M src/com/google/caja/plugin/templates/TemplateCompiler.java
M src/com/google/caja/precajole/StaticPrecajoleMap.java
M src/com/google/caja/service/AbstractCajolingHandler.java
M src/com/google/caja/util/Bag.java
M src/com/google/caja/util/ContentType.java
M src/com/google/caja/util/Maps.java
M src/com/google/caja/util/Multimaps.java
M tests/com/google/caja/ancillary/opt/EnvironmentChecksTest.java
M tests/com/google/caja/parser/ParserContextTest.java
M tests/com/google/caja/parser/html/DomMembrane.java
M tests/com/google/caja/parser/quasiliteral/ModuleFormatTest.java
M tests/com/google/caja/plugin/PipelineCacheTest.java
M tests/com/google/caja/render/OrigSourceRendererTestCase.java
M tests/com/google/caja/reporting/SnippetProducerTest.java
M tests/com/google/caja/service/ServiceTestCase.java
M tests/com/google/caja/service/TestHttpServletRequest.java
M tests/com/google/caja/service/TestHttpServletResponse.java
M tests/com/google/caja/util/CollectionsTest.java
M tests/com/google/caja/util/RhinoExecutor.java
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
