https://codereview.appspot.com/14441072/diff/1/src/com/google/caja/demos/playground/client/ui/PlaygroundView.java
File src/com/google/caja/demos/playground/client/ui/PlaygroundView.java
(right):
https://codereview.appspot.com/14441072/diff/1/src/com/google/caja/demos/playground/client/ui/PlaygroundView.java#newcode328
src/com/google/caja/demos/playground/client/ui/PlaygroundView.java:328:
// think it's an unknown exploit).
On 2013/10/15 16:13:01, ihab.awad wrote:
Sorry that didn't parse ... that what is an unknown exploit?
That whatever unsafety SES found is. Reworded:
// TODO(kpreid): Make sure we warn the user if the actual severity is
// UNSAFE_SPEC_VIOLATION or worse, so that we don't silently appear to
// have unknown security bugs.
https://codereview.appspot.com/14441072/diff/1/src/com/google/caja/demos/playground/client/ui/PlaygroundView.java#newcode419
src/com/google/caja/demos/playground/client/ui/PlaygroundView.java:419:
frame = frame.code(baseUrl, "text/html", html)
On 2013/10/15 16:13:01, ihab.awad wrote:
Any way we could squirrel in a semicolon here?
Done.
https://codereview.appspot.com/14441072/diff/1/src/com/google/caja/plugin/Config.java
File src/com/google/caja/plugin/Config.java (right):
https://codereview.appspot.com/14441072/diff/1/src/com/google/caja/plugin/Config.java#newcode124
src/com/google/caja/plugin/Config.java:124: private final Option
ID_CLASS = defineOption(
On 2013/10/15 16:13:01, ihab.awad wrote:
Interesting that this stuffery remains. :) What uses it, if we're no
longer
doing Java cajoling?
Nothing uses it; now deleted the entire Config class.
(Really could use something that detects dead classes for this job;
Eclipse doesn't seem to have one built in, and haven't gotten around to
finding something suitable.)
https://codereview.appspot.com/14441072/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
