https://codereview.appspot.com/44260044/diff/1/src/com/google/caja/ses/WeakMap.js
File src/com/google/caja/ses/WeakMap.js (right):
https://codereview.appspot.com/44260044/diff/1/src/com/google/caja/ses/WeakMap.js#newcode157
src/com/google/caja/ses/WeakMap.js:157: // IE 11 bug: WeakMaps silently
fail to store frozen objects.
For this and the other tests in this file that check for expected
patterns of breakage, does it make any sense to place the tests
themselves in repairES5 and just check the outcome of the tests here?
https://codereview.appspot.com/44260044/diff/1/src/com/google/caja/ses/WeakMap.js#newcode165
src/com/google/caja/ses/WeakMap.js:165: return;
codereview is rendering a red dot in the first column of this line, but
I have no idea what this means. Is this something other than a plain
ascii space?
https://codereview.appspot.com/44260044/diff/1/src/com/google/caja/ses/WeakMap.js#newcode581
src/com/google/caja/ses/WeakMap.js:581: if (!hmap.has(key)) {
What does this do on IE11:
var k = {};
hmap.set(k, 1);
Object.freeze(k);
hmap.set(k, 2);
alert(hmap.get(k));
If it alerts 1 because the second set silently failed, then your code
won't work, since the has test above will be fooled into thinking the
set worked.
https://codereview.appspot.com/44260044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
