yes, probably tonight.
On Mon, Jan 6, 2014 at 11:32 AM, Kevin Reid <[email protected]> wrote: > I like. MarkM, could you prepare this as a Caja change and I'll review it? > > > On Sun, Jan 5, 2014 at 11:58 AM, Mark S. Miller <[email protected]>wrote: > >> Kris just walked me through this CL, and it LGTM. We also discussed the >> idea he raises in this email and agreed that it isn't practical, as a >> monkey-patched Object.freeze has no practical way to emulate >> non-extensibility without using actual non-extensibility. >> >> >> On Sun, Jan 5, 2014 at 1:03 AM, Kris Kowal <[email protected]>wrote: >> >>> Attached is a patch for WeakMap.js that effects a tenfold performance >>> increase on Node.js. This is accomplished by reducing the complexity of the >>> hidden record on each key. >>> >>> I had hoped to eliminate the hidden record in the common case, simply >>> using a unique hidden property per WeakMap, but being able to quickly >>> handle the case where a key is sealed by a third party (bypassing our >>> monkey patches) after its initial use is difficult at best. This modest >>> change thankfully produces a noteworthy performance improvement that might >>> be enough to warrant using WeakMap in a future rendition of kriskowal/q. >>> >>> The pull request on Github is suitable for review. Attached is a patch >>> suitable for Subversion on r5653. >>> >>> https://github.com/drses/weak-map/pull/3 >>> >> -- > > --- > You received this message because you are subscribed to the Google Groups > "Google Caja Discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- Text by me above is hereby placed in the public domain Cheers, --MarkM -- --- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
