CL already submitted and closed per your LGTM. Do you want me to open a fresh one?
On Mon, Jan 27, 2014 at 11:48 AM, <[email protected]> wrote: > > https://codereview.appspot.com/54750043/diff/150001/src/ > com/google/caja/ses/WeakMap.js > File src/com/google/caja/ses/WeakMap.js (right): > > https://codereview.appspot.com/54750043/diff/150001/src/ > com/google/caja/ses/WeakMap.js#newcode452 > src/com/google/caja/ses/WeakMap.js:452: // If we crash here, values will > be one longer than keys. > Maybe spend a few words to point out that this is true only when this is > the only thing which extends the array. > > https://codereview.appspot.com/54750043/diff/150001/src/ > com/google/caja/ses/WeakMap.js#newcode487 > src/com/google/caja/ses/WeakMap.js:487: // is still void 0, since the > aliasing killed the previous key. > If it weren't so extensively commented, I would call this code > excessively clever. > > The tests we have are for deleting A from key-set [A]. Given the > cleverness, it might be worth having tests for deleting A from [A, B, C] > and [B, A] as well. > > > https://codereview.appspot.com/54750043/ > > -- > > ---You received this message because you are subscribed to the Google > Groups "Google Caja Discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- Cheers, --MarkM -- --- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
