https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/compileExprLater.js
File src/com/google/caja/ses/compileExprLater.js (right):
https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/compileExprLater.js#newcode106
src/com/google/caja/ses/compileExprLater.js:106: '["' +
prep.freeNames.join('", "') + '"], ' +
If prep.freeNames is [] then this will be [""] -- and the empty string is
not an identifier. This looks harmless since it goes into a scope object
only, but perhaps note that hazard.
https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/makeSimpleAMDLoader.js
File src/com/google/caja/ses/makeSimpleAMDLoader.js (right):
https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/makeSimpleAMDLoader.js#newcode128
src/com/google/caja/ses/makeSimpleAMDLoader.js:128: '(function(){' + src
+ '})()',
hazard if src ends with a line comment
end with ()), not )()
https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):
https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/startSES.js#newcode755
src/com/google/caja/ses/startSES.js:755: var hasLineTerminator =
(/[\u000A\u000D\u2028\u2029]/);
unnecessary parentheses
https://codereview.appspot.com/54760043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
