Reviewers: metaweta,

Description:
Whitelist <input pattern=...>.

Please review this at https://codereview.appspot.com/74860043/

Affected files (+2, -6 lines):
  M     src/com/google/caja/lang/html/html5-attributes-defs.json
  M     src/com/google/caja/lang/html/html5-attributes-whitelist.json


Index: src/com/google/caja/lang/html/html5-attributes-defs.json
===================================================================
--- src/com/google/caja/lang/html/html5-attributes-defs.json    (revision 5672)
+++ src/com/google/caja/lang/html/html5-attributes-defs.json    (working copy)
@@ -248,8 +248,7 @@
"pattern": "-?(?:[0-9]+(?:\\.[0-9]+)?| \\.[0-9]+)(?:[Ee][-+]?[0-9]+)?",
         "optional": true },
{ "key": "INPUT::PATTERN", "description": "Pattern to be matched by the form control's value",
-        "optional": true,
- "comment": "TODO(kpreid): defined to be JS regex; is there a hazard here?" },
+        "optional": true },
       { "key": "A::PING", "description": "URLs to ping",
         "mimeTypes": "*/*", "optional": true,
         "type": "URI", "uriEffect": "NEW_DOCUMENT",
Index: src/com/google/caja/lang/html/html5-attributes-whitelist.json
===================================================================
--- src/com/google/caja/lang/html/html5-attributes-whitelist.json (revision 5672) +++ src/com/google/caja/lang/html/html5-attributes-whitelist.json (working copy)
@@ -64,6 +64,7 @@
       "*::ONSUBMIT",
       "*::ONUNLOAD",
       "DETAILS::OPEN",
+      "INPUT::PATTERN",
       "INPUT::PLACEHOLDER",
       "TEXTAREA::PLACEHOLDER",
       "VIDEO::POSTER",
@@ -235,10 +236,6 @@
       { "key": "DIALOG::OPEN",
         "comment":
"TODO(kpreid): further review (can this steal page focus/pop out?)" },
-      { "key": "INPUT::PATTERN",
-        "comment":
- "TODO(kpreid): further review (allegedly a JS regexp; is that safe?)"
-        },
       { "key": "A::PING",
         "comment": "TODO(kpreid): introduce multiple-URI type for this" },
       { "key": "AREA::PING",


--

--- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to