Reviewers: metaweta,
Description:
qsaVirtualization was simply missed when attribute name virtualization
was added in r5548.
Please review this at https://codereview.appspot.com/75910045/
Affected files (+11, -5 lines):
M src/com/google/caja/plugin/domado.js
M tests/com/google/caja/plugin/test-domado-dom-guest.html
Index: src/com/google/caja/plugin/domado.js
===================================================================
--- src/com/google/caja/plugin/domado.js (revision 5675)
+++ src/com/google/caja/plugin/domado.js (working copy)
@@ -2131,7 +2131,8 @@
var qsaVirtualization = cajaVM.def({
containerClass: null,
idSuffix: idSuffix,
- tagPolicy: tagPolicy
+ tagPolicy: tagPolicy,
+ virtualizeAttrName: sanitizeOneAttr
});
/**
Index: tests/com/google/caja/plugin/test-domado-dom-guest.html
===================================================================
--- tests/com/google/caja/plugin/test-domado-dom-guest.html (revision 5675)
+++ tests/com/google/caja/plugin/test-domado-dom-guest.html (working copy)
@@ -857,6 +857,7 @@
<div id="testQuerySelector" class="testcontainer">
<p class="testQuerySelector-ac" id="testQuerySelector-ai">a</p>
<p class="testQuerySelector-bc" id="testQuerySelector-bi">b</p>
+ <p testQuerySelector-attr="foo">c</p>
</div>
<script type="text/javascript">
// TODO(kpreid): Disable this test if host browser does not provide
@@ -883,13 +884,17 @@
len === 0 ? null : nodeList[0], single);
}
+ var paragraphCount = 3;
+
assertQueryResult('.testQuerySelector-ac', ['a']);
assertQueryResult('.testQuerySelector-bc', ['b']);
assertQueryResult('#testQuerySelector-ai', ['a']);
assertQueryResult('#testQuerySelector-ai, #testQuerySelector-bi',
['a', 'b']);
- assertQueryResult('#testQuerySelector p', ['a', 'b']);
- assertEquals('scoped query', 2,
container.querySelectorAll('p').length);
+ assertQueryResult('#testQuerySelector p', ['a', 'b', 'c']);
+ assertQueryResult('[testQuerySelector-attr]', ['c']);
+ assertEquals('scoped query', paragraphCount,
+ container.querySelectorAll('p').length);
expectFailure(function() {
document.querySelector(':unrecognized');
}, 'syntax error solo', function(e) {
@@ -910,9 +915,9 @@
// test non-liveness
var list = container.querySelectorAll('p');
- assertEquals('length before change', 2, list.length);
+ assertEquals('length before change', paragraphCount, list.length);
container.appendChild(document.createElement('p')).textContent
= 'added';
- assertEquals('length after change', 2, list.length);
+ assertEquals('length after change', paragraphCount, list.length);
pass('testQuerySelector');
});
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
