https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/repairES5.js#newcode2574
src/com/google/caja/ses/repairES5.js:2574: if (typeof global.DataView
=== 'undefined') { return false; }
On 2014/05/15 20:51:51, MarkM wrote:
This is unnecessary. Do one of
if (global.DataView === undefined) // without the quotes, or better,
void 0
Done. I dispute that void 0 is better, on readability grounds.
https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/repairES5.js#newcode2575
src/com/google/caja/ses/repairES5.js:2575: if (typeof
global.DOMException === 'undefined') { return false; }
On 2014/05/15 20:51:51, MarkM wrote:
Likewise
Done.
https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):
https://codereview.appspot.com/91450047/diff/1/src/com/google/caja/ses/startSES.js#newcode1146
src/com/google/caja/ses/startSES.js:1146: var proxiesAvailable = typeof
global.Proxy !== 'undefined' &&
On 2014/05/15 20:51:51, MarkM wrote:
Again, if you're indirecting off of 'global.', there's no reason for
the typeof.
Done.
https://codereview.appspot.com/91450047/diff/1/tests/com/google/caja/plugin/browser-test-case.js
File tests/com/google/caja/plugin/browser-test-case.js (right):
https://codereview.appspot.com/91450047/diff/1/tests/com/google/caja/plugin/browser-test-case.js#newcode550
tests/com/google/caja/plugin/browser-test-case.js:550: typeof
frameGroup.iframe.Proxy !== 'undefined' &&
On 2014/05/15 20:51:51, MarkM wrote:
The combination of typeof and "." is still unneeded.
Done.
https://codereview.appspot.com/91450047/diff/1/tests/com/google/caja/plugin/test-scan-guest.js
File tests/com/google/caja/plugin/test-scan-guest.js (right):
https://codereview.appspot.com/91450047/diff/1/tests/com/google/caja/plugin/test-scan-guest.js#newcode753
tests/com/google/caja/plugin/test-scan-guest.js:753:
argsByIdentity(window.Proxy, G.none); // TODO abuse
On 2014/05/15 20:51:51, MarkM wrote:
What is this TODO about?
The scanner doesn't exercise Proxy behavior, and it should.
Referring to this as "abuse" is because the scanner's job is to look for
things like edge cases from funny arguments, most of which are expected
to fail.
https://codereview.appspot.com/91450047/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
