https://codereview.appspot.com/96420043/diff/40001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/96420043/diff/40001/src/com/google/caja/ses/repairES5.js#newcode2716
src/com/google/caja/ses/repairES5.js:2716: function bar(){}
On 2014/05/19 16:40:59, kpreid_google wrote:
space after )
Done.
https://codereview.appspot.com/96420043/diff/40001/src/com/google/caja/ses/repairES5.js#newcode2717
src/com/google/caja/ses/repairES5.js:2717:
Object.defineProperty(bar,'prototype',{value:2,writable:false});
On 2014/05/19 16:40:59, kpreid_google wrote:
space after , and :
Done.
https://codereview.appspot.com/96420043/diff/40001/src/com/google/caja/ses/repairES5.js#newcode2725
src/com/google/caja/ses/repairES5.js:2725: } else if (typeof
bar.prototype === 'object') {
On 2014/05/19 16:40:59, kpreid_google wrote:
How about saving the original bar.prototype and comparing with it
here? This
makes a stricter new-symptom check and clarifies what the bug is.
Done.
https://codereview.appspot.com/96420043/diff/40001/src/com/google/caja/ses/repairES5.js#newcode2763
src/com/google/caja/ses/repairES5.js:2763: logger.warn('prototype fixup
failed', err);
On 2014/05/19 16:40:59, kpreid_google wrote:
Curiosity: how is it safe for this to be nonfatal?
Done. I now rethrow the err.
https://codereview.appspot.com/96420043/diff/40001/src/com/google/caja/ses/repairES5.js#newcode4429
src/com/google/caja/ses/repairES5.js:4429: id:
'DEFINE_PROPERTY_CONFUSES_FUNC_PROTO',
On 2014/05/19 16:40:59, kpreid_google wrote:
How about putting this problem next to the other ones that use
repair_DEFINE_PROPERTY rather than at the end?
Done.
https://codereview.appspot.com/96420043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
