Reviewers: felix8a,
Description:
r5701, which introduced a bottleneck function for window.onerror
invocations, did not consider the case of guests without DOM.
Move domicile.handleUncaughtException to be
Domado.handleUncaughtException so that it can be invoked even if
there is no domicile object.
handleUncaughtException now takes the window (or global/imports)
object as an argument, and is not otherwise changed.
Arguably it should be moved out of domado.js entirely, but I
currently think that it makes the most sense there, since onerror
is a browser feature rather than a JS feature, and we do not yet
have a "browser features other than the DOM" module. (One reason
we might gain such is if we provide setTimeout-and-friends in the
no-DOM case, which we probably should.)
Please review this at https://codereview.appspot.com/157300043/
Affected files (+83, -66 lines):
M src/com/google/caja/plugin/domado.js
M src/com/google/caja/plugin/html-emitter.js
M src/com/google/caja/plugin/ses-frame-group.js
M tests/com/google/caja/plugin/test-cajajs-invocation.js
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.