https://codereview.appspot.com/188160043/diff/20001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/188160043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode34
src/com/google/caja/ses/repairES5.js:34: * //provides ses.noFuncPoison
On 2014/12/14 17:33:31, kpreid2 wrote:
By the way, I think it is a mistake to have internal-use properties
and external
ones mixed up on the 'ses' object. We should consider refactoring so
all of the
hookup glue is something like "ses.internal.verifyStrictFunctionBody"
and so on.
This would be aligned with your previously-expressed plan (IIRC) to
rename
"cajaVM" to "ses".
This shouldn't be part of this change, of course — just want to keep
the thought
alive.
Acknowledged.
https://codereview.appspot.com/188160043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode2686
src/com/google/caja/ses/repairES5.js:2686: return
Object.getOwnPropertyDescriptor(arguments, 'caller').get;
On 2014/12/14 17:33:32, kpreid2 wrote:
Given that this had to be changed, it seems possibly valuable to have
a
self-test that the resulting object is actually what it should be (at
least that
it is a function).
Done. In looking at this, I realized that we weren't testing that the
[[ThrowTypeError]] object is unique, which, btw, it isn't on FF34 until
the noPoison test cleans things up. So now tests this as well.
(I tested the test by temporarily turning off one of the deletes in the
noPoison test and saw that the NOT_UNIQUE test reported the problem
appropriately.)
https://codereview.appspot.com/188160043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
