https://codereview.appspot.com/198470043/diff/20001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/198470043/diff/20001/src/com/google/caja/ses/repairES5.js#newcode512
src/com/google/caja/ses/repairES5.js:512: strictForEachFn([null,
undefined, true, 1, 'x', {}], function(v) {
On 2015/02/14 00:38:46, MarkM wrote:
On 2015/02/13 21:30:37, kpreid_google wrote:
> for style consistency, void 0 instead of undefined?
>
> I'd like to see some hairier pretend-to-be-the-object test cases,
like
>
> 1. a Proxy whose target would pass (but you may not want to depend
on Proxy
> yet).
>
> 2. {valueOf() { return anActualInstance; }}
Extremely good idea! The proxy case fails on FF 35.0.1 which we must
still
support, so I added extra logic to survive when that self-test fails,
and added
comments explaining why this is currently safe. All other browsers I
tested so
far -- Chrome, FF Nightly, Safari, and Opera pass fine. I won't be
able to test
IE until tomorrow, but I will test it before submitting.
So, with these caveats, Done. PTAL.
Works fine on IE11. New snapshot for other updated comments re IE11
testing.
https://codereview.appspot.com/198470043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
