LGTM
https://codereview.appspot.com/199650043/diff/1/src/com/google/caja/ses/useHTMLLogger.js
File src/com/google/caja/ses/useHTMLLogger.js (right):
https://codereview.appspot.com/199650043/diff/1/src/com/google/caja/ses/useHTMLLogger.js#newcode203
src/com/google/caja/ses/useHTMLLogger.js:203: return test;
I don't like that this as it is behaves oppositely to normal relative
URI resolution.
Given the circumstances, I suggest a condition at this point checking
for /^[-+.\w]+:/ (that is, has a URI scheme) and indicate failure (i.e.
return something like "data:,Failed%20to%20resolve%20" + test)
otherwise. That'll at least make it never return nonsense.
https://codereview.appspot.com/199650043/diff/1/src/com/google/caja/ses/useHTMLLogger.js#newcode258
src/com/google/caja/ses/useHTMLLogger.js:258: link.href =
'http://es5.github.io/#x' + encodeURIComponent(section);
We can https: here
https://codereview.appspot.com/199650043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
