LGTM
As discussed privately, I will be submitting this on MarkM's behalf
because he's away and we want this fixed soon.
https://codereview.appspot.com/222570043/diff/100001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/222570043/diff/100001/src/com/google/caja/ses/repairES5.js#newcode1321
src/com/google/caja/ses/repairES5.js:1321: // the ones we cannot test?
FYI: The problem is we don't know what the structure of the caller's
document is. It is _normally_ at least
<html><head></head><body></body></html>, but we cannot guarantee that it
contains any of those nodes.
The first case is the most correct document structure.
The second case is less correct but preferable over the alternatives if
<body> is missing (e.g. if the document is still being parsed, or the
document is a frameset).
The third case is necessary if nothing but a documentElement (<html>)
exists.
The fourth case is necessary if a documentElement does not exist (a
highly unusual but valid state of the DOM).
https://codereview.appspot.com/222570043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
