On 2015/07/09 17:47:11, kpreid_google wrote:
https://codereview.appspot.com/251030043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/251030043/diff/1/src/com/google/caja/plugin/domado.js#newcode1052
src/com/google/caja/plugin/domado.js:1052: switch (arguments.length -
1) {
On 2015/07/08 22:12:51, MarkM wrote:
> Is this really clearer than switching on argument.length and
incrementing the
> case labels? If not, please do that.
I think that the numbers currently used are more relevant to _what we
are
implementing_ (XHR API) as opposed to the +1 numbers which contain an
implementation detail (the privates arg).
Do you disagree?
Yes, for this case I agree. Still LGTM
https://codereview.appspot.com/251030043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
