Nevermind. It is telling me the time that these changes were committed anywhere, not when they were pushed to github, right?
On Mon, Feb 22, 2016 at 6:44 PM, Mark Miller <[email protected]> wrote: > Well that's strange. I just now did a "git push" which succeeded. I then > went to https://github.com/google/caja/commits/master and it showed the > commit, but said it happened 16 minutes ago. Less that one minute happened > between my push and looking at the github page. > > On Mon, Feb 22, 2016 at 6:34 PM, Mark Miller <[email protected]> wrote: > >> Well, my other change, which does not alter .next, got stuck the same >> place, as did bug I filed seem to -- though I did not scroll that browser >> window to the bottom at the time. My assumption that they are the same is >> your comment "related to iterators IIRC". >> >> I'm going to proceed and try to commit both. >> >> >> On Mon, Feb 22, 2016 at 6:25 PM, <[email protected]> wrote: >> >>> >>> >>> https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js >>> File src/com/google/caja/ses/repairES5.js (right): >>> >>> >>> https://codereview.appspot.com/288270043/diff/1/src/com/google/caja/ses/repairES5.js#newcode1848 >>> src/com/google/caja/ses/repairES5.js:1848: * As of ES6, for all the >>> builtin constructors except >>> On 2016/02/22 23:25:42, kpreid_google wrote: >>> >>>> You have "except >>>> (except" in this comment. Also, maybe put "that make" before the list >>>> >>> of >>> >>>> exceptions? >>>> >>> >>> Same below. >>>> >>> >>> Done. >>> >>> https://codereview.appspot.com/288270043/ >>> >> >> >> >> -- >> Cheers, >> --MarkM >> > > > > -- > Cheers, > --MarkM > -- Cheers, --MarkM -- --- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
