https://codereview.appspot.com/285550043/diff/40001/tools/workflow
File tools/workflow (right):
https://codereview.appspot.com/285550043/diff/40001/tools/workflow#newcode40
tools/workflow:40: # $ tools/workflow validate-change
Since "ant runtests" doesn't actually work at the moment, we should say
something about how to cope.
https://codereview.appspot.com/285550043/diff/40001/tools/workflow#newcode44
tools/workflow:44: # $ git merge --ff-only <my-branch-name>
When I got here, I could not remember what branch name I used. I
remembered "git branch" and look for the star. But this happened after
"git checkout master". You should explain how to get your branch name.
https://codereview.appspot.com/285550043/diff/40001/tools/workflow#newcode115
tools/workflow:115: private-snapshot )
Assuming private snapshots are not ready yet, you should mention in the
instructions that they are coming.
https://codereview.appspot.com/285550043/diff/40001/tools/workflow#newcode122
tools/workflow:122: checkReviewersHappyAndMatchesReview
no such command was found
https://codereview.appspot.com/285550043/diff/40001/tools/workflow#newcode123
tools/workflow:123: if ! "$tools_dir/log_helper.py" fail-if-private
"$@"; then
no fail-if-private was found. This if concluded that we had a private cl
and gave us the message below.
https://codereview.appspot.com/285550043/diff/40001/tools/workflow#newcode141
tools/workflow:141: echo TODO IMPLEMENT
Is the reason this isn't implemented is that you have to fork the "I am
really pushing" vs "I am posting a pull request"? Perhaps these should
be two separate commands anyway?
Since "tools/workflow push" doesn't work yet, for those who can "git
push" you should mention that in the workflow text above. Probably the
same for a pull request, but I don't know.
https://codereview.appspot.com/285550043/diff/40001/tools/workflow#newcode178
tools/workflow:178: else
little bits of extra whitespace here and there.
https://codereview.appspot.com/285550043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
