On 2016/04/28 19:43:52, felix8a wrote:
lgtm.
meta-comment: I've already forgotten most of what I know about the
scanner, and
I'm not finding it easy to reconstruct that understanding, so this is
just a
fairly superficial review. The changes locally seem to make sense, and
I'm
trusting that you understand the implications of the change better
than me.
“Everyone knows that debugging is twice as hard as writing a program in
the first place. So if you're as clever as you can be when you write it,
how will you ever debug it?”
I'm fairly confident that this change is a strict improvement. It
introduces a kludge (the pseudo-ctors) but everything else is
straightforward, and the kludge is less “clever” than my attempt to make
Context directly understand the iterator prototypes.
https://codereview.appspot.com/297960043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
