On Jan 9, 2009, at 3:05 AM, Joe Walker wrote:

> Hi,
>
> Whilst digging through CalendarEventEntry.getTimes, I found that
> ExtensionPoint.getRepeatingExtension does a few things might be worth
> discussion.
>
> - It's a getter and yet it mutates the state of the object. Granted
> the state change ought to be transparent, but I can't help think that
> somewhere down the line this could cause a problem.
>
> - It grants access to what it probably the internal state of the
> object? It looks from the perspective of CalendarEventEntry, which has
> addTime() and getTimes() that the list of times is managed by
> CalendarEventEntry, however if you wish to clear the list you need to
> do getTimes().clear().
>
> - Many of the objects ('When' in this particular case) are missing
> equals(), hashCode() and toString(). Is this a deliberate policy? They
> could all be useful.
>
> Joe.


Joe,
I'm not as familiar with the Java client as some of the others, but  
these are all look like valid concerns to me. Feel free to file bug  
reports/feature requests here:

        http://code.google.com/p/gdata-java-client/issues/list

-- 
Trevor Johns

-- 
Trevor Johns


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Google Calendar Data API" group.
To post to this group, send email to 
[email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/google-calendar-help-dataapi?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to