Hi Darren, Right now, the mailing lists and code review tool are not closely integrated. So, it is an either-or choice that is up to each project.
Some projects already do a lot of code reviews by looking at diffs in emails and responding to them. If a given project follows that process, the project owner can set the email notification address for all review comments to be the same as the mailing list address, so any web-based comments will go to the mailing list too. And, some projects have members that prefer the web UI, or never got started with doing code reviews of emailed diffs. Doing reviews via the web UI has the advantages of being easier for many users to read and understand, and of having a clearer summary of scores and review coverage. If your project follows this process, I think you are correct to just remind your contributors to post review comments to the web UI. If you like, you can probably add a note about that in the footer of email messages sent over your mailing list. Thanks, jason! On Wed, Apr 15, 2009 at 7:40 AM, Darren Pearce <[email protected]> wrote: >> Sorry, there's no way to do this right now. Sending diffs in emails >> is the norm in most open source development, since it encourages peers >> to review code changes by lowering the effort to near-zero -- the >> diffs appear in the inbox, and all peers have to do is reply to the >> email. > > Sorry to butt in to the conversation but I would just like to ask a question > given this response. :-) > Given what you have said, what do you feel is the role of commit comments > within Google Code compared to simply replying to a commit email? > We frequently have this confusion on our project. I encourage the > development team to post comments on commits on the web-site rather than > through private email if at all possible. Just today in fact, I asked a > colleague to (re-)post the text of his email to the site as a commit > comment. To me, this seems in keeping with the spirit of Open Source and we > try to do it where possible. > It would be ideal if we allowed email responses to commits and this turned > into commit comments automatically. I seem to remember seeing a similar (if > not the same) issue but I can't find it now. > Interested to hear your thoughts. > Many thanks, > :Darren. > -- > ---------------------------------------------------------------------- > :Darren :Pearce > ---------------------------------------------------------------------- > *** Shop & Donate: http://buy.at/campuskids *** > ---------------------------------------------------------------------- > [email protected] > Postdoctoral Researcher > London Knowledge Lab, University of London > ---------------------------------------------------------------------- > [email protected] > Visiting Research Fellow > Informatics, University of Sussex > http://www.informatics.sussex.ac.uk/users/darrenp/ > ---------------------------------------------------------------------- > [email protected] > http://www.linkedin.com/in/darrenpearce > ---------------------------------------------------------------------- > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Hosting at Google Code" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-code-hosting?hl=en -~----------~----~----~----~------~----~------~--~---
